Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chromadb dependency #1456

Closed
wants to merge 2 commits into from

Conversation

mmurraysans
Copy link

Description

This updates the ChromaDb dependency to allow newer version of ChromaDb.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran the included unit tests and lint checks to ensure everything still passed after dependency resolution.

Please delete options that are not relevant.

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@Dev-Khant
Copy link
Member

@mmurraysans Thanks for making this change but unfortunately we can't directly update the Chromadb version for embedchain as other frameworks(like CrewAI) use our package and it causes dependency conflicts.

So please free to update chromadb locally,

@mmurraysans
Copy link
Author

@mmurraysans Thanks for making this change but unfortunately we can't directly update the Chromadb version for embedchain as other frameworks(like CrewAI) use our package and it causes dependency conflicts.

So please free to update chromadb locally,

sounds good and thanks for letting me know! would allowing a broader version range work maybe? that way other frameworks would still be able to pull the older version if needed?

@Dev-Khant
Copy link
Member

Sure we can plan to include that. As a PR #1391 is already open for dependency issues, I would suggest you should close this PR and we can include all the changes there.

@mmurraysans
Copy link
Author

sounds good. thanks!

@mmurraysans mmurraysans closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants