-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add response to m.add() call #1732
Conversation
mem0/memory/main.py
Outdated
@@ -179,7 +182,7 @@ def add( | |||
self.graph.user_id = "USER" | |||
added_entities = self.graph.add(data) | |||
|
|||
return {"message": "ok"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to consider the graph memory as well in the return statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added,also change the script, please check.
@femto Can you please resolve the merge conflicts? |
@Dev-Khant Hello, doesn't your side says that you have some platform code, |
@femto we have already resolved your issue in one of our previous commits. |
@prateekchhikara resolved the conflict |
Description
Added useful return information for m.add() call,
discussed in #1499,
where original implementation doesn't have useful information returned after calling m.add(),
which is not good.
Fixes
#1499
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
use the following script, change password to suitable value
outputs:
Checklist:
Maintainer Checklist