Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and formatting fixes #554

Merged
merged 11 commits into from
Sep 5, 2023
Merged

Lint and formatting fixes #554

merged 11 commits into from
Sep 5, 2023

Conversation

Dev-Khant
Copy link
Member

Description

Lint and formatting fixes

Type of change

  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Dev-Khant
Copy link
Member Author

@taranjeet Here are the lint and formatting fixes.

embedchain/bots/__init__.py Outdated Show resolved Hide resolved
embedchain/bots/whatsapp.py Outdated Show resolved Hide resolved
@Dev-Khant Dev-Khant requested a review from taranjeet September 5, 2023 06:05
@Dev-Khant
Copy link
Member Author

@taranjeet Please have a look

@cachho
Copy link
Contributor

cachho commented Sep 5, 2023

@Dev-Khant we had a big change, can you take another look? there are merge conflicts. thanks.

@Dev-Khant
Copy link
Member Author

Its fixed

@cachho
Copy link
Contributor

cachho commented Sep 5, 2023

@Dev-Khant when I run make format lint I pickup a lot more. Can you include that?

@Dev-Khant Dev-Khant mentioned this pull request Sep 5, 2023
7 tasks
@taranjeet
Copy link
Member

looks good to me.

Copy link
Member

@taranjeet taranjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@taranjeet taranjeet merged commit 1292425 into mem0ai:main Sep 5, 2023
taranjeet added a commit that referenced this pull request Sep 6, 2023
Co-authored-by: cachho <admin@ch-webdev.com>
Co-authored-by: Taranjeet Singh <reachtotj@gmail.com>
@Dev-Khant Dev-Khant deleted the lint-fixes branch June 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants