Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine-grained control over emitted metrics #365

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

Qizot
Copy link
Member

@Qizot Qizot commented Dec 21, 2021

This PR introduces more fine-grained control over which metrics reporting gets compiled along with the core instead of turning them on and off all at once. This change allows having e.g. elements `init/terminate turned on all the time without any performance penalty or in case if we simply don't care about specific metrics (which again can be quite heavy).

@Qizot Qizot force-pushed the fine-grained-telemetry-metrics branch from 32298ec to 4cc6fb6 Compare December 21, 2021 14:44
@Qizot Qizot requested a review from andpodob December 21, 2021 14:45
Copy link
Contributor

@andpodob andpodob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Qizot Qizot merged commit 3193167 into master Dec 21, 2021
@Qizot Qizot deleted the fine-grained-telemetry-metrics branch December 21, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants