Fix the bug with pipeline persisting in Zombie mode after self-terminating with terminate: :normal action
#538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
added
the
no-changelog
FelonEkonom
reviewed
Mar 15, 2023
| @@ -95,6 +95,8 @@ defmodule Membrane.Core.Pipeline.ActionHandler do | |||
|
|
|||
| @impl CallbackHandler | |||
| def handle_action({:terminate, :normal}, _cb, _params, state) do | |||
| state = %{state | terminating?: true} | |||
There was a problem hiding this comment.
callbacks above don't change state, so maybe move this line to LifecycleController.handle_terminate/1?
There was a problem hiding this comment.
Well, the only usage of Parent.LifecycleController.handle_terminate/1 is here, so we can safely move it ;)
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
…mbraneframework/membrane_core into bugfix/persistent_zombie_mode
mat-hek
approved these changes
Mar 16, 2023
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional small changes (removing unused variables and aliases from tests) have also been performed since my credo has been failing.