Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve in_progress_memory metric in performance benchmark #579

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Improve in_progress_memory metric in performance benchmark #579

merged 6 commits into from
Jul 19, 2023

Conversation

varsill
Copy link
Contributor

@varsill varsill commented Jul 18, 2023 •
edited
Loading

This PR:

  • Adds synchronous GC launch before the initial memory measurement in benchmark
  • Removes calculation of the initial_memory in in_progress_memory metric

@varsill varsill changed the title Add synchronous GC launch before the initial memory measurement in benchmark Improve in_progress_memory metric in performance benchmark Jul 18, 2023
@varsill varsill added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label Jul 18, 2023
@varsill varsill marked this pull request as ready for review July 18, 2023 12:40
@varsill varsill requested a review from mat-hek as a code owner July 18, 2023 12:40
mat-hek
mat-hek approved these changes Jul 18, 2023
View reviewed changes
benchmark/metric/in_progress_memory.ex Outdated
defp do_loop(acc, initial_memory) do
acc = acc ++ [:erlang.memory(:total) - initial_memory]
defp do_loop(acc) do
acc = acc ++ [:erlang.memory(:total)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's prepend & reverse

benchmark/metric/in_progress_memory.ex Outdated Show resolved Hide resolved
@varsill varsill merged commit 40304d0 into master Jul 19, 2023
@varsill varsill deleted the better_memory_performance_test branch July 19, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varsill @mat-hek