Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort component state fields in the error logs in the order from the most to the least important #614

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Sort component state fields in the error logs in the order from the most to the least important #614

merged 14 commits into from
Oct 4, 2023

Conversation

FelonEkonom
Copy link
Member

@FelonEkonom FelonEkonom commented Sep 29, 2023 •
edited
Loading

Closes #616

@FelonEkonom FelonEkonom added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label Sep 29, 2023
mat-hek
mat-hek requested changes Oct 2, 2023
View reviewed changes
lib/membrane/core/inspect.ex Outdated Show resolved Hide resolved
lib/membrane/core/inspect.ex Outdated Show resolved Hide resolved
lib/membrane/core/inspect.ex Outdated Show resolved Hide resolved
FelonEkonom and others added 3 commits October 2, 2023 16:49
@FelonEkonom @mat-hek
Update lib/membrane/core/inspect.ex
0b23edb 
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
@FelonEkonom @mat-hek
Update lib/membrane/core/inspect.ex
9d6c756 
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
@FelonEkonom
Merge remote-tracking branch 'origin/master' into defimpl-inspect-for…
380a4bc 
…-states
@FelonEkonom FelonEkonom requested a review from mat-hek October 2, 2023 14:50
@mat-hek mat-hek removed their request for review October 3, 2023 10:27
FelonEkonom and others added 2 commits October 3, 2023 14:16
@FelonEkonom FelonEkonom requested a review from mat-hek October 3, 2023 13:01
@FelonEkonom FelonEkonom force-pushed the defimpl-inspect-for-states branch from 763b164 to c1c09dd Compare October 3, 2023 14:00
@FelonEkonom FelonEkonom force-pushed the defimpl-inspect-for-states branch from c1c09dd to 2ef54a7 Compare October 3, 2023 14:02
mat-hek
mat-hek requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@mat-hek mat-hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we spoke, let's use the order of fields as specified in each state module

@FelonEkonom FelonEkonom requested a review from mat-hek October 4, 2023 13:29
@FelonEkonom FelonEkonom changed the title defimpl Inspect for components states Sort component state fields in the error logs in the order from the most to the least important Oct 4, 2023
@FelonEkonom FelonEkonom merged commit 56ebe56 into master Oct 4, 2023
@FelonEkonom FelonEkonom deleted the defimpl-inspect-for-states branch October 4, 2023 13:46
FelonEkonom added a commit that referenced this pull request Oct 12, 2023
@FelonEkonom
Revert "Sort component state fields in the error logs in the order fr…
db4792f 
…om the most to the least important (#614)"

This reverts commit 56ebe56.
FelonEkonom added a commit that referenced this pull request Oct 16, 2023
@FelonEkonom
Revert "Revert "Sort component state fields in the error logs in the …
0dac019 
…order from the most to the least important (#614)""

This reverts commit db4792f.
FelonEkonom added a commit that referenced this pull request Oct 16, 2023
@FelonEkonom @mat-hek
Sort component state fields in the error logs in the order from the m…
9403974 
…ost to the least important (#614)

* defimpl Inspect for components states

* Update lib/membrane/core/inspect.ex

Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>

* Update lib/membrane/core/inspect.ex

Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>

* Update lib/membrane/core/inspect.ex

Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>

* Implement suggestion from CR, add new field to the state

* Fix compilation error

* Specify docker_membrane version to latest

* Revert "Fix compilation error"

This reverts commit 5b1e1cb.

* Pull docker membrane latest before performance tests

* Impelement reviewer suggestion

* Add function doc

* Update changelog

---------

Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
FelonEkonom added a commit that referenced this pull request Oct 16, 2023
@FelonEkonom
Sort component state fields in the error logs in the order from the m…
2345a0a 
…ost to the least important

This commit contains changes originally introduced in #614

-----
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
@FelonEkonom FelonEkonom mentioned this pull request Oct 16, 2023
Merged
FelonEkonom added a commit that referenced this pull request Oct 16, 2023
@FelonEkonom
Sort component state fields in the error logs in the order from the m…
df6c992 
…ost to the least important (#641)

This commit contains changes originally introduced in #614

-----
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Inspect protocol in component states
2 participants
@FelonEkonom @mat-hek