Refactor demand mechanism #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
FelonEkonom
force-pushed
the
refactor-demand-mechanism
branch
from
58e7f3c to
0f7b0ca
Compare
FelonEkonom
force-pushed
the
refactor-demand-mechanism
branch
from
93bdfb4 to
9c309b0
Compare
FelonEkonom
added
the
no-changelog
mat-hek
requested changes
Apr 2, 2024
Comment on lines
48
to
53
| # Match in the function below is caused by a fact, that handle_spec_started is the only callback, that | ||
| # might be executed in between handling actions returned from other callbacks. | ||
| # This callback has been deprecated and should be removed in v2.0.0, along with the if statement below. | ||
|
|
||
| @impl CallbackHandler | ||
| def handle_end_of_actions(state) do | ||
| def handle_end_of_actions(:handle_spec_started, state), do: state |
There was a problem hiding this comment.
element doesn't have this callback
| @spec handle_buffer(Pad.ref(), [Buffer.t()] | Buffer.t(), State.t()) :: State.t() | ||
| def handle_buffer(pad_ref, buffers, state) do | ||
| @spec handle_ingoing_buffers(Pad.ref(), [Buffer.t()] | Buffer.t(), State.t()) :: State.t() | ||
| def handle_ingoing_buffers(pad_ref, buffers, state) do |
There was a problem hiding this comment.
Suggested change
| def handle_ingoing_buffers(pad_ref, buffers, state) do | |
| def handle_incoming_buffers(pad_ref, buffers, state) do |
| if pad_data.direction == :input, | ||
| do: raise("cannot snapshot atomic counter in input pad") | ||
| if pad_data.direction == :input do | ||
| raise("cannot snapshot atomic counter in input pad") |
mat-hek
approved these changes
Apr 3, 2024
| @@ -30,7 +30,7 @@ defmodule Membrane.Core.Element.DemandController do | |||
| with {:ok, pad_data} when not pad_data.end_of_stream? <- PadModel.get_data(state, pad_ref), | |||
| %State{playback: :playing} <- state do | |||
| if pad_data.direction == :input do | |||
| raise("cannot snapshot atomic counter in input pad") | |||
| raise("cannot snapshot atomic counter in input pad #{inspect(pad_ref)}") | |||
There was a problem hiding this comment.
Suggested change
| raise("cannot snapshot atomic counter in input pad #{inspect(pad_ref)}") | |
| raise Membrane.ElementError, "Cannot snapshot atomic counter in input pad #{inspect(pad_ref)}" |
|
@FelonEkonom BTW I recall you wanted to refactor |
FelonEkonom
force-pushed
the
refactor-demand-mechanism
branch
from
94f6dbf to
ad5612a
Compare
FelonEkonom
force-pushed
the
refactor-demand-mechanism
branch
from
ad5612a to
1430ecc
Compare
|
@mat-hek I know, but then I decided that I would rather focus more on the code related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #706