Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if GitHub Action add_pr_to_smackore_board works again #806

Merged
merged 9 commits into from
May 28, 2024

Conversation

bartkrak
Copy link
Contributor

No description provided.

@bartkrak bartkrak requested a review from mat-hek as a code owner May 15, 2024 22:54
@bartkrak bartkrak requested a review from FelonEkonom May 15, 2024 22:55
@bartkrak bartkrak removed the request for review from FelonEkonom May 15, 2024 23:33
@bartkrak bartkrak marked this pull request as draft May 15, 2024 23:33
@bartkrak bartkrak requested a review from FelonEkonom May 16, 2024 01:01
@bartkrak bartkrak marked this pull request as ready for review May 16, 2024 01:04

if item_id == None:
print("Error occurred in get_ticket.py: item_id == None, provided JSON[items]: ", project_items)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Error occurred in get_ticket.py: item_id == None, provided JSON[items]: ", project_items)
print("Error occurred in get_ticket.py: ID of ticket related to PR", pr_url, "not found in the provided JSON")
print("Provided JSON:", full_json)

@@ -1,13 +1,20 @@
import sys, json;

full_json = json.load(sys.stdin)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

print("An exception occurred in get_author_origin.py, provided JSON: ", membrane_team)
print("Provided PR_AUTHOR: ", pr_author)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Provided PR_AUTHOR: ", pr_author)
print("Provided PR_AUTHOR: ", pr_author)
sys.exit(1)

sys.exit(1)
else:
print(item_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(item_id)
print(item_id)

bartkrak and others added 4 commits May 22, 2024 19:23
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
Co-authored-by: Feliks Pobiedziński <38541925+FelonEkonom@users.noreply.github.com>
@bartkrak bartkrak requested a review from FelonEkonom May 22, 2024 17:24
@FelonEkonom
Copy link
Member

You can add no-changelog label to the PR, to satisfy Enfore CHANGELOG rule

@bartkrak bartkrak added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label May 28, 2024
@FelonEkonom FelonEkonom merged commit ca34336 into master May 28, 2024
4 of 6 checks passed
@FelonEkonom FelonEkonom deleted the add_pr_to_smack_test branch May 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants