Fix skipping parameters #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
approved these changes
Sep 20, 2023
| @@ -559,7 +558,7 @@ defmodule Membrane.H264.Parser do | |||
| Membrane.Time.t(), | |||
| :au | :nalu, | |||
| stream_structure() | |||
| ) :: Buffer.t() | |||
| ) :: Buffer.t() | [Buffer.t()] | |||
| defp wrap_into_buffer(access_unit, pts, dts, :au, output_stream_structure) do | |||
There was a problem hiding this comment.
Just a NIT suggestion to the code you haven't changed - I don't think there is a need to assign the result to buffer and then immediately return that buffer
Noarkhh
force-pushed
the
fix-skipping-parameters
branch
from
c150646 to
8c9b28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where parameter set in the same access unit as non-idr nalus when option
skip_until_keyframeis set totrueare being skipped.