Add overlay description struct and use it in unified way for both the initial overlay and dynamic overlay changes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initial overlay and dynamic overlay changess
WojciechBarczynski
approved these changes
Jul 24, 2024
Comment on lines
+33
to
+42
| initial_overlay = options.initial_overlay | ||
| opts_y = initial_overlay |> Map.take([:x, :y, :blend_mode]) |> Enum.to_list() | ||
|
|
||
| uv_x = | ||
| if is_integer(initial_overlay.x), do: div(initial_overlay.x, 2), else: initial_overlay.x | ||
|
|
||
| uv_y = | ||
| if is_integer(initial_overlay.y), do: div(initial_overlay.y, 2), else: initial_overlay.y | ||
|
|
||
| opts_uv = [x: uv_x, y: uv_y, blend_mode: initial_overlay.blend_mode] |
There was a problem hiding this comment.
I would just take out this logic into a separate function, because it's repeated here and in handle_parent_notification
WojciechBarczynski
merged commit 9fb5d91
into
@WojciechBarczynski/add_dynamical_overlay_update
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.