Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_secret_manager_secret "automatic" -> "auto" #76

Closed
cassus opened this issue Oct 7, 2023 · 1 comment · Fixed by #80 or #81
Closed

google_secret_manager_secret "automatic" -> "auto" #76

cassus opened this issue Oct 7, 2023 · 1 comment · Fixed by #80 or #81
Assignees
Labels
bug Something isn't working

Comments

@cassus
Copy link

cassus commented Oct 7, 2023

Hi!

Thank for this great module!

Describe the bug

With the new 5.0.0 google provider [registry.terraform.io/hashicorp/google] automatic was renamed to auto. The previous versions had a deprecation warning about this.

╷
│ Error: Unsupported argument
│ 
│   on .terraform/modules/db1_prod_socket_url/main.tf line 33, in resource "google_secret_manager_secret" "secret":
│   33:     automatic = length(var.replication) > 0 ? null : true
│ 
│ An argument named "automatic" is not expected here.
╵
@cassus cassus added the bug Something isn't working label Oct 7, 2023
@memes
Copy link
Owner

memes commented Oct 9, 2023

Hello @cassus, and thanks for the report. I've been seeing the deprecation for a while but haven't updated to v5 of Google provider yet because it has many changes that need to be tested across the TF modules I maintain. As a result, there will be a v2.1.2 release that enforces a '< 5' constraint and then a v2.2.0 release that has a '>= 5.0' constraint, after testing.

Related to #54

memes added a commit that referenced this issue Oct 20, 2023
Google provider v5 enforced a change in how automatic replication was
specified; this change makes the `automatic` => `auto` stanza change and
supports setting a KMS key for Google-managed replication with a user
provided KMS key through the variable `auto_replication_kms_key_name`.

The newer versions of Google provider also support `annotations` in
addition to `labels`; this commit adds an optional `annotations`
variable.
Closes #76
@memes memes closed this as completed in #80 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants