-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 on Ubuntu #281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antepusic
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Sorry not sure I understood, what will be the default version 3.10 or 3.11? |
@as51340 The recommended version would be 3.10, but it all depends on what users have on their system, of course. I hope that answers your question. |
as51340
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for Python 3.11 on Ubuntu. I created a new job that tests only on Python 3.11 Ubuntu machine (
build_and_test_ubuntu_python3_11
).Here is what it does:
The reason for that is that
torch
does not support Python 3.11, but that should be a part of its next release (2.1.0) on Oct 4th.This means we can add support for Python 3.11 on Ubuntu without DGL features. Although
torch
might be an extra for DGL, I thinktorch
is a prerequisite for our features with DGL to work (and we are installing it in our other jobs withpoe install-pyg-cpu
).Pull request type
Please delete options that are not relevant.
Related issues
Closes #203
TODO
Document this.