Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 on Ubuntu #281

Merged
merged 10 commits into from
Sep 22, 2023
Merged

Conversation

katarinasupe
Copy link
Contributor

@katarinasupe katarinasupe commented Sep 21, 2023

Description

Adding support for Python 3.11 on Ubuntu. I created a new job that tests only on Python 3.11 Ubuntu machine (build_and_test_ubuntu_python3_11).
Here is what it does:

 poetry install --extras "arrow docker"
 poetry run pytest -vvv -m "not slow and not ubuntu and not docker and not dgl"

The reason for that is that torch does not support Python 3.11, but that should be a part of its next release (2.1.0) on Oct 4th.

This means we can add support for Python 3.11 on Ubuntu without DGL features. Although torch might be an extra for DGL, I think torch is a prerequisite for our features with DGL to work (and we are installing it in our other jobs with poe install-pyg-cpu).

Pull request type

Please delete options that are not relevant.

  • Build or packaging related changes

Related issues

Closes #203

TODO

Document this.

@katarinasupe katarinasupe marked this pull request as ready for review September 21, 2023 15:27
@katarinasupe katarinasupe added the status: draft PR is in draft phase label Sep 21, 2023
@antepusic antepusic assigned antepusic and katarinasupe and unassigned antepusic Sep 21, 2023
@antepusic antepusic added this to the v1.5.0 milestone Sep 21, 2023
@katarinasupe katarinasupe changed the title Update dependencies Add support for Python 3.11 on Ubuntu Sep 21, 2023
@katarinasupe katarinasupe added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Sep 21, 2023
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@as51340
Copy link
Contributor

as51340 commented Sep 22, 2023

Sorry not sure I understood, what will be the default version 3.10 or 3.11?

@katarinasupe
Copy link
Contributor Author

@as51340 The recommended version would be 3.10, but it all depends on what users have on their system, of course. I hope that answers your question.

@katarinasupe katarinasupe merged commit dbc2de1 into main Sep 22, 2023
@katarinasupe katarinasupe linked an issue Sep 22, 2023 that may be closed by this pull request
@antepusic antepusic deleted the update-dependencies branch September 22, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready for review
Projects
Status: Done
3 participants