#![deny(clippy::undocumented_unsafe_blocks)]: Add and fix existing safety comments
#1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/deny-unsafe_op_in_unsafe_fn
branch
from
f575f39
to
6c4dad4
Compare
kkysen
force-pushed
the
kkysen/deny-clippy-undocumented_unsafe_blocks
branch
from
7388f20
to
4fd4893
Compare
…block to pass `clippy::undocumented_unsafe_blocks`. Most of these are in closures.
kkysen
force-pushed
the
kkysen/deny-clippy-undocumented_unsafe_blocks
branch
from
4fd4893
to
3ceb813
Compare
kkysen
force-pushed
the
kkysen/deny-unsafe_op_in_unsafe_fn
branch
from
6c4dad4
to
998c8d6
Compare
rinon
requested changes
Jul 11, 2024
rinon
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#![deny(clippy::undocumented_unsafe_blocks)]and#![deny(clippy::missing_safety_doc)]#1270.This adds
#![deny(clippy::undocumented_unsafe_blocks)]to thelibrav1dcrate. Since we don't yet runclippyin CI, this doesn't do anything yet, but that's good, since we can turn that on once we fix all of the errors. This PR only turns on the lint and fixes the existing safety comments into ones that the lint recognizes.