Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents sending excessive value updates to the native side #12

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

pulyaevskiy
Copy link
Contributor

Fixes #11.

This addresses two issues:

  1. Ensures that composing range is always set to the last known value for data sent to the native side.
  2. Prevents sending remote updates if current value (including composing range) is the same the the last known value.

cc @stemuk

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #12 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #12      +/-   ##
=========================================
+ Coverage   91.79%   91.8%   +0.01%     
=========================================
  Files          32      32              
  Lines        2607    2612       +5     
=========================================
+ Hits         2393    2398       +5     
  Misses        214     214
Impacted Files Coverage Δ
packages/zefyr/lib/src/widgets/input.dart 93.18% <100%> (+0.49%) ⬆️
packages/zefyr/lib/src/widgets/editable_text.dart 93.79% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f6f9e...0965c7a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant