Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter for QuillJS notation #337

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Jon-Salmon
Copy link

Pretty much as stated, a converter for converting between notus and quill formats.

@cgestes
Copy link
Collaborator

cgestes commented Jun 8, 2020

It doesnt pass the build. most probably a formatting issue?

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #337 into master will decrease coverage by 1.34%.
The diff coverage is 66.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   91.89%   90.55%   -1.35%     
==========================================
  Files          11       12       +1     
  Lines        1074     1133      +59     
==========================================
+ Hits          987     1026      +39     
- Misses         87      107      +20     
Impacted Files Coverage Δ
packages/notus/lib/src/convert/quill.dart 66.10% <66.10%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d69499...e7540b0. Read the comment docs.

@Jon-Salmon
Copy link
Author

Jon-Salmon commented Jun 8, 2020

Any idea why this still isn't passing @cgestes ? I've removed the extra import line and added unit tests

@cgestes
Copy link
Collaborator

cgestes commented Jun 9, 2020

Formatting?

@Jon-Salmon
Copy link
Author

Yup, it was one erroneous line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants