Feature/text alignment #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amir-P
force-pushed
the
feature/text_alignment
branch
from
5cd1007 to
eec1e9b
Compare
pulyaevskiy
reviewed
Dec 15, 2021
Comment on lines
+44
to
+45
| if (_prototypePainter.textAlign == value) return; | ||
| _prototypePainter.textAlign = value; |
There was a problem hiding this comment.
I believe setting textAlign on prototype painter would not have any effect... unless you're using the painter as placeholder for current alignment value? In which case I'd probably recommend to actually introduce _textAlign private field to make it more explicit and avoid any possibility of prototype painter messing with this value in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #437 for description and previous discussions.