Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial on how to convert a protobuf message and filter certain fields to a resulting map. #42

Merged
merged 13 commits into from
Feb 15, 2024

Conversation

marcoshuck
Copy link
Contributor

@marcoshuck marcoshuck commented Jan 31, 2024

This PR addresses the discussion raised in #41

I ended up copying the CamelCase code from the function to my personal open source project to avoid code duplications due to the limitation of the github protobuf project being deprecated, we can remove the dependency if it doesn't make sense to keep it in here.

Bump go version to 1.21
Add example in README
Add disclaimer about potential solutions for the naming function

Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
@marcoshuck
Copy link
Contributor Author

Seems CI pipelines are failing, looking into it.

Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
README.md Show resolved Hide resolved
@mennanov
Copy link
Owner

mennanov commented Feb 1, 2024

Seems CI pipelines are failing, looking into it.

Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR.

@mennanov
Copy link
Owner

mennanov commented Feb 4, 2024

Seems CI pipelines are failing, looking into it.

Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR.

I ended up not upgrading the go version in go.mod since it may impact the existing users of the library as according to the docs (https://go.dev/doc/modules/gomod-ref#go):

Go toolchains refuse to use modules declaring newer Go versions.

I updated Github Actions tests for go 1.21 though.

@marcoshuck marcoshuck requested a review from mennanov February 12, 2024 16:39
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2de6178) 89.27% compared to head (05ee728) 89.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files           2        2           
  Lines         401      401           
=======================================
  Hits          358      358           
  Misses         27       27           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@mennanov mennanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but please revert the go.sum changes

go.sum Outdated Show resolved Hide resolved
Copy link
Owner

@mennanov mennanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mennanov mennanov merged commit 7cfb817 into mennanov:master Feb 15, 2024
11 checks passed
@mennanov
Copy link
Owner

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants