-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial on how to convert a protobuf message and filter certain fields to a resulting map. #42
Conversation
Bump go version to 1.21 Add example in README Add disclaimer about potential solutions for the naming function Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Seems CI pipelines are failing, looking into it. |
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR. |
I ended up not upgrading the go version in
I updated Github Actions tests for go 1.21 though. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 2 2
Lines 401 401
=======================================
Hits 358 358
Misses 27 27
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but please revert the go.sum
changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for contributing! |
This PR addresses the discussion raised in #41
I ended up copying the
CamelCase
code from the function to my personal open source project to avoid code duplications due to the limitation of the github protobuf project being deprecated, we can remove the dependency if it doesn't make sense to keep it in here.