Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra slot for metadata #147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove extra slot for metadata #147

wants to merge 3 commits into from

Conversation

sritchie
Copy link
Member

@sritchie sritchie commented Aug 15, 2023

TODO: decide if this actually works in all cases for the affected types. Am I always hanging metadata off something that can take it?

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 53.70% and project coverage change: -0.11% ⚠️

Comparison is base (e16b569) 86.05% compared to head (4320644) 85.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   86.05%   85.95%   -0.11%     
==========================================
  Files          98       98              
  Lines       15335    15295      -40     
  Branches      834      827       -7     
==========================================
- Hits        13197    13147      -50     
- Misses       1304     1321      +17     
+ Partials      834      827       -7     
Files Changed Coverage Δ
src/emmy/structure.cljc 88.04% <45.71%> (-0.04%) ⬇️
src/emmy/series.cljc 59.01% <46.23%> (-2.78%) ⬇️
src/emmy/operator.cljc 76.08% <72.72%> (-1.65%) ⬇️
src/emmy/polynomial.cljc 83.28% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant