Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ravenClient.install() not invoked #5

Closed
mjgp2 opened this issue Jul 4, 2018 · 2 comments
Closed

ravenClient.install() not invoked #5

mjgp2 opened this issue Jul 4, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@mjgp2
Copy link

mjgp2 commented Jul 4, 2018

You need to call ravenClient.install(); to complete installation
@mentos1386
Copy link
Owner

@mjgp2 Thanks for reporting this. It seams i missed it here https://github.com/mentos1386/nest-raven/blob/master/lib/raven.providers.ts#L9. Kinda weird that it worked when i tested it.

I'll try to fix it today or in the weekend. If you want you can also make a PR for it, shouldn't be that big of a change.

@mentos1386 mentos1386 added the bug Something isn't working label Jul 4, 2018
mentos1386 added a commit that referenced this issue Jul 14, 2018
@mentos1386
fix: raven client provider not calling .install()
b09b05e 
#5
@mentos1386
Copy link
Owner

Sorry it took me this long to fix this. It's now released in v2.0.1!

@mjgp2
Copy link
Author

mjgp2 commented Jul 16, 2018

Ah nice one! It's not that long at all :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjgp2 @mentos1386