Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KAN-78] 음식점 조회 API에 MySQL 연결 #50

Merged
merged 2 commits into from
May 22, 2024
Merged

[KAN-78] 음식점 조회 API에 MySQL 연결 #50

merged 2 commits into from
May 22, 2024

Conversation

sinkyoungdeok
Copy link
Member

@sinkyoungdeok sinkyoungdeok commented May 21, 2024

  • 정렬 처리 남음.

찜한 데이터를 위해서 아래 개선도 필요함

AS-IS

  1. ES에서 모든 데이터를 조회 (찜 필터 제외한 필터는 여기서 모두 적용)
  2. ES에서 전달받은 데이터를 MySQL로 id in절 쿼리 + 찜 필터

TO-BE

  1. MySQL로 찜 필터 선처리
  2. ES에서 찜처리된 데이터를 기반으로 필터 처리 + 정렬 로직
  3. MySQL에서 in 절 쿼리

시간 여유가 살짝 있으니, 테스트코드 작성 후 개선하는것도 고려.

@sinkyoungdeok sinkyoungdeok self-assigned this May 21, 2024
@github-actions github-actions bot requested review from goathoon and one0955 May 21, 2024 15:59
@sinkyoungdeok sinkyoungdeok merged commit 2696b4e into main May 22, 2024
3 checks passed
@sinkyoungdeok sinkyoungdeok deleted the KAN-78 branch May 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant