[KAN-99] 리뷰 작성,수정,삭제시 음식점 평균 별점 및 리뷰 개수 반영 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+57
to
+63
| private fun applyReviewCountAndAvgRating(restaurantId: Long, requestRating: Double) { | ||
| val restaurant = restaurantRepository.findById(restaurantId).getOrNull() | ||
| ?: throw NotFoundRestaurantException() | ||
| val beforeCount = restaurant.reviewCount | ||
| restaurant.reviewCount = beforeCount + 1 | ||
| restaurant.ratingAvg = (restaurant.ratingAvg * beforeCount + requestRating) / (beforeCount + 1) | ||
| } |
There was a problem hiding this comment.
요 함수는 여기에 추가하지말고, restaurant에 비즈니스 메서드로 추가해서 진행하면 더 좋을 것 같습니다!
Comment on lines
+34
to
+45
| private fun applyReviewCountAndAvgRating(restaurantId: Long) { | ||
| val restaurant = restaurantRepository.findById(restaurantId).getOrNull() | ||
| ?: throw NotFoundRestaurantException() | ||
| val beforeCount = restaurant.reviewCount | ||
| if (beforeCount <= 1) { | ||
| restaurant.ratingAvg = 0.0 | ||
| restaurant.reviewCount = 0 | ||
| } else { | ||
| restaurant.ratingAvg = (restaurant.ratingAvg * beforeCount) / (beforeCount - 1) | ||
| restaurant.reviewCount = beforeCount - 1 | ||
| } | ||
| } |
| val reviews: List<ReviewResponseDto> | ||
| val reviews: List<ReviewResponseDto>, | ||
| @Schema(description = "Pagination 정보") | ||
| val pageable: Pageable |
There was a problem hiding this comment.
List가아니라 Page<>로 전달부탁드립니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.