Update bresser_7in1.c mass concentration naming #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right, this comes from #2698 and should not have slipped through. We may need a check to warn on uncommon keys. "Change to pm_2_5_ug_m3, pm_10_ug_m3, BREAKING change to Bresser-7in1" Let this PR sit for ~2 weeks so others can notice and comment if needed. Ping later if we miss to merge please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the mass concentration of air quality sensors are named different in the fineoffset_wh45 protocol and rtl_433_mqtt_hass.py script, this is to get the Bresser 7in1 protocol align to have the same name everywhere.
(This is my very first PR / comment, please excuse any mistakes I'm probably unaware of)