Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anvi-gen-variability-matrix due to missing min-ratio-of-competings-nts #457

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

blankenberg
Copy link
Contributor

No description provided.

@meren
Copy link
Member

meren commented Feb 15, 2017

Hey Daniel,

Thank you very much! I have no idea who took it out, because I am sure it was in there at some point :)

In fact this fix reminded me of something else. The output of this program is a subset of the information that is generated by anvi-gen-variability-profile (i.e., this one focuses only on the competing nts information). I feel like maybe we should remove or merge this one into anvi-gen-variability-profile to reduce confusion. But that is a decision that can be done later :)

Thank you for the fix!

@meren meren merged commit d002f16 into merenlab:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants