-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiler now computes codon variability instead of AA #809
Conversation
--profile-AA-frequencies goes, and --profile-SCVs comes.
this migration script will remove the SAAVs table :( so it will hurt a lot of people.
Although the previous config files will need to be fixed now :/
anvio/__init__.py
Outdated
'help': "Anvi'o can perform accurate characterization of codon frequencies in genes during profiling. While having\ | ||
codon frequencies opens doors to powerful evolutionary insights in downstream analyses, due to its\ | ||
computational complexity, this feature comes 'off' by default. Using this flag you can rise against the\ | ||
authority as you always should, and make anvi'o to profile codons."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "to profile codons" just say "profile codons". Would've changed it myself, but I'm on my phone
@@ -419,7 +438,7 @@ def insert_additional_fields(self, entry_ids=[]): | |||
and should it be GlxSer or SerGlx? There are three rules that define our conventions: | |||
|
|||
1. Competing_aas ALWAYS appear in alphabetical order. Even if Cys is most common, and | |||
Ala is second most commond, competing_aas = AlaCys. | |||
Ala is second most commond, competing_aas = AlaCys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common, not commond
…to codon-variability pull "better wording" changes
I tested that the branch was doing what it was supposed to by comparing the output of
Then I ran the following Python script to test their equivalence:
After a couple of commits to codon-variability the output is now:
@meren if you're happy with the changes merge it :) |
Great! Let's take this to master, and see if we run into any issues, then. |
This PR implements codon-level variability profiling.
The engine
AA
continues to work seamlessly inanvi-gen-variability-profile
, and amino acid frequencies are computes from codon frequency data. A new engine,CDN
, is now also available.These changes required an upgrade in the db version, but the PR contains a well-tested migration script.