fix: Loading teams for team option of author filter/validator #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmayerhofer
force-pushed
the
fix-teams-context
branch
from
45bdca5
to
08ea1b4
Compare
robinmayerhofer
force-pushed
the
fix-teams-context
branch
from
08ea1b4
to
de1d43e
Compare
robinmayerhofer
force-pushed
the
fix-teams-context
branch
from
de1d43e
to
c4de8d1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
=======================================
Coverage 92.90% 92.91%
=======================================
Files 112 110 -2
Lines 2877 2878 +1
Branches 576 578 +2
=======================================
+ Hits 2673 2674 +1
Misses 185 185
Partials 19 19
☔ View full report in Codecov by Sentry. |
|
@shine2lay could you also check out this PR? Thx! |
shine2lay
approved these changes
May 12, 2023
|
🎉 This PR is included in version 2.17.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix loading teams for team option of author filter/validator.
Context
My previous PR #710 added an author validator. However, the API classes (mocked in the tests) access the context, and the context in
lib/validators/options_processor/options/team.jsis not the one I expected (it's a special validator context, different from the context inlib/filters/options_processor/options/team.js(correct one).API calls are mocked for unit tests, but they log information taken from the context, and this doesn't work with the validator context.
Changes
I introduced a new function in
lib/validators/options_processor/teams.jsand moved most of the logic there (shared for filter/validator), and removed theoptions_processor/options/team.jsclasses because we don't always have the correct context there.This method is called prior to processing the other options (and potentially results in an early return if unsuccessful), and then the
teamkey is simply removed from the options.This follows the pattern for similar cases, for example, see lib/validators/changeset.js#L58