-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add author validator #710
feat: Add author validator #710
Conversation
2df8bfa
to
5be930b
Compare
Hi @shine2lay - thanks for the very fast review & merge! I've checked the release job, and it seems like it ran but did not release anything.
Is this because the commit message on |
@RM98 tbh, i am not sure myself, it seems it stops since a few PRs back. would you mind taking a look? worse case, scenario, i think I should be able to do a manual release |
Hey! I checked the latest release jobs that ran - and I believe that the issue for this PR is the commit message. It needs the Regarding the previous PR (link to the release job run): The previous release worked (npm publishing & creating the release in the GitHub repo), but adding the comment to the PR did not work because of some rate-limiting issues (see here). I don't see this as a big problem - and the fix would need to happen on the side of the semantic-release plugin I guess (support checking whether the comment was posted or not). => I would neglect this & prefer triggering a manual release (or merging something with an appropriate commit message that then triggers a release) |
i've tagged and released + published |
TYVM! |
Goal
Add an
author
validator that behaves exactly like theauthor
filter.How
I created
lib/validators/author.js
, which is basically the same aslib/filters/author.js
. I saw no convention on how to do an object that can be a filter and validator at the same time.I also created
lib/validators/options_processor/options/team.js
, which is pretty much whatlib/filters/options_processor/options/team.js
is. However, there is a subtle difference when implementing it: the method signature forprocess
contains an extra argument forfilters
, thus, we cannot reuse theTeamProcessor
.