Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flag to enable sqlite3_unlock_notify() #350

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

riyaz-ali
Copy link
Contributor

This PR fixes #349 by adding a flag (-DSQLITE_ENABLE_UNLOCK_NOTIFY) to enable sqlite3_unlock_notify() interface required by the sqlite3 library.

@riyaz-ali riyaz-ali added the bug Something isn't working label Dec 14, 2022
@riyaz-ali riyaz-ali requested a review from a team as a code owner December 14, 2022 10:49
@riyaz-ali riyaz-ali self-assigned this Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #350 (e881104) into main (164bbdf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   71.04%   71.04%           
=======================================
  Files          57       57           
  Lines        4445     4445           
=======================================
  Hits         3158     3158           
  Misses        918      918           
  Partials      369      369           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riyaz-ali riyaz-ali merged commit 3a908ac into main Dec 16, 2022
@riyaz-ali riyaz-ali deleted the fix/missing-sqlite-symbol branch December 16, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails at runtime because of missing symbol
2 participants