Netsuite dynamic host addressing #2
Conversation
|
@merit-sno this looks awesome, nice work on the quick PR. For testing/linting I've just cloned things locally and done some light poking mostly just for syntax. Do we have more formal test steps to validate the functionality of these changes? |
netsuite/client.py
Outdated
| def __init__(self, **kwargs): | ||
| """ | ||
| Assign the dynamic host domain component to a class variable | ||
| """ | ||
| wsdl_url = kwargs['wsdl_url'] | ||
| kwargs.pop('wsdl_url',None) | ||
|
|
||
| parsed_wsdl_url = urlparse(wsdl_url) | ||
| self._wsdl_url = f'{parsed_wsdl_url.scheme}://{parsed_wsdl_url.netloc}/' | ||
|
|
||
| super().__init__(**kwargs) |
There was a problem hiding this comment.
Could this maybe turn in to:
def __init__(self, wsdl_url, *args, **kwargs):
"""
Assign the dynamic host domain component to a class variable
"""
parsed_wsdl_url = urlparse(wsdl_url)
self._wsdl_url = f'{parsed_wsdl_url.scheme}://{parsed_wsdl_url.netloc}/'
super().__init__(*args, **kwargs)It makes the init() requirement of wsdl_url more explicit and saves you the trouble of having to manipulate args/kwargs for the super(). (Generally, kwargs are optional arguments while positional args are required. It's also not very common in Python to pop kwargs like that.)
Then when you instantiate the class you remove the key and pass the URL as a positional argument.
return NetSuiteTransport(
self._generate_wsdl_url(),
session=self.session,
cache=self.cache,
)There was a problem hiding this comment.
And for a deeper-dive into args/kwargs: https://www.digitalocean.com/community/tutorials/how-to-use-args-and-kwargs-in-python-3
There was a problem hiding this comment.
It seems like bad form to mix arguments by position, generic list, and key/value all in the same call.
Problem
NetSuite WSDL now relies on dynamic host addresses for accessing subscriber based WSDL documents. With NetSuite 2020.1, this becomes a requirement, and zeep appears to have a failure to recognize NetSuite's use of relative addressing.
Solution
Wrap zeep.transports.transport with a dynamic address manager that updates the get and post services to use subscriber assigned dynamic addressing.