Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma dangle #1

Closed
jantimon opened this issue Aug 12, 2016 · 3 comments
Closed

Comma dangle #1

jantimon opened this issue Aug 12, 2016 · 3 comments

Comments

@jantimon
Copy link

error

Comma dangle decreases the quality of git-history and tends to cause merge conflicts as you have to change lines although you are not changing it.

The rule comes from >=IE7 because IE used to handle the comma dangle as syntax error.
For IE8+/Chrome/FF/Safari/Node that's not and issue anymore.

Do you see further benefits to follow this rules?
I would suggest to turn this rule off.

@easingthemes
Copy link

Still, it would be good to have some rule about it.

Maybe to use:
"always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

@jantimon
Copy link
Author

Agreed "always-multiple" as suggested by @easingthemes is cleaner than turning it off

smollweide pushed a commit that referenced this issue Sep 20, 2016
@smollweide
Copy link
Contributor

Done: v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants