Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify bounty in payer and pauser callbacks. #3

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Identify bounty in payer and pauser callbacks. #3

merged 4 commits into from
Mar 9, 2024

Conversation

merklejerk
Copy link
Owner

This prevents an attack where someone can pause the protocol for another bounty or drain the payer for another bounty by simply reusing their Pauser or Payer contracts. 😇

@merklejerk
fix pauser and payer reuse vuln
f8af414 
update testnet scripts
fix broken tests
update README
@merklejerk merklejerk marked this pull request as ready for review March 8, 2024 23:21
merklejerk and others added 2 commits March 8, 2024 18:55
@merklejerk
update readme
de57e17
@JordanCason
Add Test to Validate Mitigation of Unauthorized Bounty Claim (#5)
8ebe82b 
Added test to check for bounty using another pauser payer
@merklejerk
Return pay amount (#4)
d72a175 
* return paid amount from claims

* update readme

* update flow img

* update flow img
@merklejerk merklejerk merged commit 50888b9 into main Mar 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanCason JordanCason JordanCason approved these changes

@justinschuldt justinschuldt Awaiting requested review from justinschuldt justinschuldt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merklejerk @JordanCason