Skip to content

Commit

Permalink
fix: call .node to check for node existence
Browse files Browse the repository at this point in the history
  • Loading branch information
@FezVrasta
FezVrasta committed Apr 8, 2024
1 parent 3ccfea8 commit 2f5f48e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/mermaid/src/diagrams/sequence/svgDraw.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ const drawActorTypeParticipant = async function (elem, actor, conf, isFooter) {
);

let height = actor.height;
if (rectElem.node) {
if (rectElem.node()) {

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when parsing a sequenceDiagram > should not show sequence numbers per default 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:212:5

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when parsing a sequenceDiagram > should show sequence numbers when autonumber is enabled 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:224:5

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is tspan 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is fo 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is old 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is undefined 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle one actor and a centered note 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1682:5

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle one actor and a note to the left 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1698:5

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle one actor and a note to the right 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1714:5

Check failure on line 404 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle two actors 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:404:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:513:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1729:5
const bounds = rectElem.node().getBBox();
actor.height = bounds.height;
height = bounds.height;
Expand Down

0 comments on commit 2f5f48e

Please sign in to comment.