Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable build Next.js app after 10.2.0 update SyntaxError: Cannot use import statement outside a module goes from dayjs #4438

Closed
dimaMachina opened this issue May 29, 2023 · 4 comments
Closed

Unable build Next.js app after 10.2.0 update SyntaxError: Cannot use import statement outside a module goes from dayjs #4438

dimaMachina opened this issue May 29, 2023 · 4 comments
Labels
Type: Bug / Error Something isn't working or is incorrect

Comments

@dimaMachina
Copy link

dimaMachina commented May 29, 2023 •
edited

Description

we are unable to build our Next.js docs after the 10.2.0 update
ardatan/feTS/actions/runs/5113409462/jobs/9192576118?pr=194
rollback to 10.1.0 fixes issue

I guess this PR caused issue #4285

Steps to reproduce

https://github.com/ardatan/feTS/tree/7aa27d39e369e4e9c2ac51d43bf5051bfb7d814d

yarn
yarn workspace website build

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version: 10.2.0
  • Browser and Version: [Chrome, Edge, Firefox]

Additional Context

No response
@dimaMachina dimaMachina added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels May 29, 2023
@sidharthv96
Copy link
Member

Issue in present in live editor too. https://github.com/mermaid-js/mermaid-live-editor/actions/runs/5088034742/jobs/9143981898?pr=1231

@subhash-halder
Copy link
Contributor

@sidharthv96 I think reverting the changes in #4285 and upgrading to dayjs version 2.* would fix the issue also we will be using esm. I have checked with dayjs 2.0.0-alpha.4 it's working fine.

@sidharthv96 sidharthv96 removed the Status: Triage Needs to be verified, categorized, etc label Jun 1, 2023
@knsv
Copy link
Collaborator

knsv commented Jun 1, 2023

@amsubhash Trying this path, reverting the changes from #4285 together with the dayjs version 2.0.0-alpha.4 but mermaid does not build then. Will revert to the #4285 and return to the previous version of dayjs until we find a better solution.

knsv added a commit that referenced this issue Jun 1, 2023
@knsv
#4438 Reverted to the changes from #4285
98e7595
@knsv knsv mentioned this issue Jun 1, 2023
Merged
4 tasks
knsv added a commit that referenced this issue Jun 1, 2023
@knsv
Merge pull request #4445 from mermaid-js/4438-revering-to-non-esm-use…
48e5d74 
…-of-dayjs

#4438 Reverted to the changes from #4285
@sidharthv96
Copy link
Member

Fixed in 10.2.1

sidharthv96 added a commit that referenced this issue Jun 12, 2023
@sidharthv96
Merge branch 'develop' into sidv/splitUnicode
c85e479 
* develop:
  Update docs
  Rename info to note
  Rename "info" to "note"
  Update all patch dependencies
  Fix Directives Documentation
  Update tutorial link
  Run build
  Fix link to Tutorials from n00b-overview page
  UPdated version to 10.2.3
  Remove old changelog
  Remove old changelog
  Setting version to 10.2.2
  #4446 Improved regular expression
  #4446 Updating the cleanup criteria
  #4438 Reverted to the changes from #4285
  Fix download
  Fix compile error in docs.
  Fix Contributor link in homepage
  Update docs
  Add hint on "flowchart" and "graph" (and some more styling)
@aloisklink aloisklink mentioned this issue Jun 21, 2024
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knsv @dimaMachina @subhash-halder @sidharthv96