Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4157: Inject only fontFamily without replacing themeVariables #4160

Merged
merged 4 commits into from
Feb 28, 2023
Merged

fix #4157: Inject only fontFamily without replacing themeVariables #4160

merged 4 commits into from
Feb 28, 2023

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Feb 28, 2023 •
edited
Loading

📑 Summary

Inject only fontFamily without replacing themeVariables

Resolves #4157

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 📓 have added documentation (if appropriate)
  • 🔖 targeted develop branch

@sidharthv96 sidharthv96 added this to the 10.0.1 milestone Feb 28, 2023
@knsv knsv merged commit 114ab87 into develop Feb 28, 2023
@Yokozuna59 Yokozuna59 deleted the sidv/fix4157 branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.

themeVariables are incorrectly overridden
2 participants
@sidharthv96 @knsv