Show Full Title in Pie Chart SVG #5596
Conversation
github-actions
bot
added
the
Type: Bug / Error
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5596 +/- ##
==========================================
- Coverage 5.86% 5.85% -0.01%
==========================================
Files 274 274
Lines 41086 41104 +18
Branches 488 488
==========================================
Hits 2408 2408
- Misses 38678 38696 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
@yari-dewalt can you add some tests in |
|
@sidharthv96 I went ahead and added some tests to cover the long title case, hopefully they're what you were looking for. I also added the default pieWidth in the totalWidth calculation in the renderer so there are not cut offs if there is no title / the title is not long enough |
* develop: (87 commits) fix(class): mermaid-js#5624 Reset direction to default in classDiagram ci: upgrade to pnpm/action-setup@v4 to avoid CI failures chore(deps): update dependency eslint-plugin-unicorn to v54 chore(deps): update dependency eslint-plugin-jsdoc to v48.5.0 chore(deps): update all patch dependencies Sync docs folder Add Doctave to .cspell libraries Adds Doctave to list of integrations chore: update browsers list chore: Cleanup tsconfig chore: Fix lint Apply suggestions from code review chore: Remove extra words from cspell chore: Log granular rebuild times fix: Message wrap fix: Message wrap chore: Use `??` instead of `||` chore: Organise imports chore: Remove unused variables chore: Remove cross-env from eslint ...
|
Good set of tests @yari-dewalt! |
📑 Summary
Aims to fix the title of a pie chart overflowing outside the bounds of the rendered SVG.
Resolves #5567
📏 Design Decisions
The goal was to keep the rendering the same but to account for the title length if it surpasses the length of the overall diagram. If so, it will update the total width of the diagram and offset the chart so it remains centered under the title text. It also maintains the margin on both sides.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch