-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2853 gantt today #5717
Feature/2853 gantt today #5717
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
What would be the next step to get this merged? Any thoughts? Thanks in advance!
|
72192fe
to
be28003
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5717 +/- ##
==========================================
+ Coverage 4.64% 4.65% +0.01%
==========================================
Files 375 374 -1
Lines 51976 51994 +18
Branches 587 613 +26
==========================================
+ Hits 2414 2422 +8
- Misses 49562 49572 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I was hoping the 2 new argos tests would create code coverage for |
ec196cc
to
547f61a
Compare
547f61a
to
dc1a50d
Compare
commit: |
If you are looking for an interim solution: #2853 (comment) |
Feature request: #2853
dc1a50d
to
8f2c395
Compare
No traction, closing. |
📑 Summary
Add 'today' support in Gantt charts as per request 2853.
Resolves #2853
📏 Design Decisions
When the today keyword is present, its value overrides the default
new Date()
which is always "now". The value can be either a date in the Gantt's date format, or a duration.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch