feat: Return parsed config from mermaid.parse
#5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d053284 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5831 +/- ##
=======================================
Coverage 5.00% 5.00%
=======================================
Files 338 337 -1
Lines 48216 48205 -11
Branches 551 576 +25
=======================================
Hits 2413 2413
+ Misses 45803 45792 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
* develop: chore: Fix check feat: Preview release
commit: |
aloisklink
approved these changes
Sep 9, 2024
* develop: chore(deps): update dependency eslint-plugin-jsdoc to v50 chore: add git command and set safe dir Version Packages Adding changeset Cleanup of test-file Updated cypress test for self-loops Fix for issues with self loops rebuild docs add another maybe-undefined operator elk pass linter fix import make rendering-util/types a real ts file
Co-authored-by: Alois Klink <alois@aloisklink.com>
* develop: [autofix.ci] apply automated fixes Create red-beans-cross.md remove tsconfig compiler option paths linting replace mermaid/dist with relative paths more , linting add test for out-of-tree tsc project replace with mermaid/dist
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This enables users to get the config that's defined in the frontmatter or directives when parsing a mermaid diagram.
📏 Design Decisions
We're returning the config along with diagramType.
Because we were returning an object, it's not a breaking change.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.