Sequence Diagram: Start participant timeline from the bottom of the participant

[jayaprabhakar]

📑 Summary

On the sequence diagram, the participant timeline should start from the bottom of the participant instead of the top. In normal cases it doesn't look bad because the line color is the same as the background color of the participant, but when using rough mode, the this portion of the line shows up.

This PR fixes that.

Resolves #5716

📏 Design Decisions

In the old code, the y1 position was set the actorY + 5 instead, this changes to actorY + actor.height.
This ensures, y1 position of the line starts at the bottom of the actor.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

⚠️ No Changeset found

Latest commit: e564c39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	e564c39
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/66e0b24734af480009eacf31
😎 Deploy Preview	https://deploy-preview-5853--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5853

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5853

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5853

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5853

commit: e564c39

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.00%. Comparing base (dd03043) to head (e564c39).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
packages/mermaid/src/diagrams/sequence/svgDraw.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5853   +/-   ##
=======================================
  Coverage     5.00%   5.00%           
=======================================
  Files          338     337    -1     
  Lines        48216   48205   -11     
  Branches       551     576   +25     
=======================================
  Hits          2413    2413           
+ Misses       45803   45792   -11     

Flag	Coverage Δ
unit	5.00% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/mermaid/src/diagrams/sequence/svgDraw.js	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Sep 10, 2024, 9:08 PM

[mermaid-bot]

@jayaprabhakar, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.