Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Add process log command #154

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Add process log command #154

merged 1 commit into from
Sep 18, 2019

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Sep 12, 2019

Add the command process:log in order to display all the executions that match a specific process and display useful information

Here is an example of a process log

[execute-task-x] - H74Qqq8nT5JZ9GSJmuSWLN5benWZPkUb5pYcvQLsoZX - serviceA - taskX
        inputs:  { message: 'event' }
        outputs: { value: 'serviceA#taskX' }

[toTaskY] - DTjy36ApV5YVbyXm67iWeAsD9uCbZETcPL1TbUPwHeYJ - serviceB - taskY
        inputs:  { inputA: 'serviceA#taskX' }
        outputs: { res: 'serviceA#taskX => serviceB#taskY' }

What do you think about this log? Any idea of how to improve it?

@antho1404 antho1404 changed the title dd process log command Add process log command Sep 12, 2019
@antho1404 antho1404 self-assigned this Sep 12, 2019
@antho1404 antho1404 added the enhancement New feature or request label Sep 12, 2019
@antho1404 antho1404 modified the milestone: next Sep 12, 2019
@antho1404 antho1404 added this to the next milestone Sep 12, 2019
@krhubert
Copy link
Contributor

I like logs :)

service "serviceB" - instance DTjy36ApV5YVbyXm67iWeAsD9uCbZETcPL1TbUPwHeYJ execute "taskX"
        inputs:  {
          inputA: 'taskX' 
        }
        outputs: {
           res: 'taskX => taskY'
        }
recived from `Map`...

Above one is just a bad proposal, but here are a few things to consider:

  • the first line with seperated with - doesn't give us an option for adding things later. Maybe use more description? What do you think about the service name first?
  • pretty print inputs and outputs (multiple lines)
  • I don't understand the notation of outputs, what exactly it means
  • can we put information about the receiving node (the type of node in that case Map) and maybe print the map to show the input mapping
  • just a thought about the API (not related to logs). The execution has StepID fields which I feel is not intuitive at all (don't a have a better name for now).

@antho1404
Copy link
Member Author

the first line with seperated with -

I agree that's not really nice but I would love to have this log concise. I can put some \t as separator

What do you think about the service name first?

You could have multiple tasks in your process that uses the same service so it's more "unique" to have the node like that we can see quickly what step has been processed.

pretty print inputs and outputs

I even wanted to put all that in one line only, it might be a lot of logs.

I don't understand the notation of outputs, what exactly it means

This is the end of execution for a task so there are the inputs for this task and the outputs/result of the task

can we put information about the receiving node

This only log the results of the executions as filters and map are internal and there is no api to have these events. Also, the receiving node is displayed, that's the one in [] eg: [execute-task-x]

@NicolasMahe NicolasMahe merged commit acec113 into master Sep 18, 2019
@NicolasMahe NicolasMahe deleted the feature/process-log branch September 18, 2019 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants