Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api>deploy: pass env variables as an Option #662

Closed
wants to merge 3 commits into from
Closed

api>deploy: pass env variables as an Option #662

wants to merge 3 commits into from

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Dec 20, 2018

No description provided.

@ilgooz ilgooz self-assigned this Dec 20, 2018
@ilgooz ilgooz requested a review from a team December 20, 2018 17:18
@ilgooz ilgooz mentioned this pull request Dec 20, 2018
Closed
6 tasks
@ilgooz ilgooz force-pushed the feature/api-deploy-env-option branch from 9291cfa to cb52777 Compare December 20, 2018 18:12
krhubert
krhubert suggested changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@krhubert krhubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env shouldn't be passed an option. PR to close for me.

Don't make dynamic programming language from go. Options are used invalid here.

@antho1404
Copy link
Member

antho1404 commented Dec 22, 2018 •
edited
Loading

It depend here if we consider the env variable as optional or required but that can be empty.
If we consider as optional then we can use the options for that.
If we consider as required but that can be empty then the current implementation is fine.

I'm ok with both, they both have their benefits/inconvenient.

Let's not waste too much time for some small decisions like that. If the feature is working and there is not absolute necessity to change we can keep it as it is.

@NicolasMahe NicolasMahe closed this Jan 4, 2019
@NicolasMahe NicolasMahe deleted the feature/api-deploy-env-option branch January 4, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert requested changes

@antho1404 antho1404 antho1404 approved these changes

Assignees

@ilgooz ilgooz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilgooz @antho1404 @krhubert @NicolasMahe