Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cont'd] Configure services with envs #654

Closed
wants to merge 16 commits into from

Conversation

@ilgooz ilgooz requested a review from a team December 19, 2018 20:21
@ilgooz ilgooz force-pushed the feature/passing-env-improvements branch from 0f814f6 to f46240a Compare December 19, 2018 20:30
@NicolasMahe
Copy link
Member

@ilgooz could you split this PR into multiple small one please?
I agree with most of the change but not all so it will be easier split this PR into small ones.

@ilgooz ilgooz changed the base branch from feature/passing-env to dev December 20, 2018 10:19
@ilgooz ilgooz added the on hold label Dec 20, 2018
@ilgooz
Copy link
Contributor Author

ilgooz commented Dec 20, 2018

this PR split into smaller ones as described in the first message

@ilgooz ilgooz closed this Dec 20, 2018
@ilgooz ilgooz deleted the feature/passing-env-improvements branch December 20, 2018 17:44
@ilgooz ilgooz removed the request for review from a team December 20, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants