Improve marketplace mesg.yml definition #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why the "configuration" is not part of the mesg.yml or is it just something you forgot ? |
Nice catch. This PR has been done before the extraction of configuration ;) |
ilgooz
reviewed
Apr 16, 2019
…/mesg-foundation/core into ss/marketplace-better-object-def
This was referenced Apr 18, 2019
ilgooz
reviewed
Apr 18, 2019
| type: Boolean | ||
| optional: true | ||
| object: | ||
| type: Object |
There was a problem hiding this comment.
we could have typed Parameter here as well if we implemented this feature https://forum.mesg.com/t/service-definition-support-recursive-types/260
ilgooz
approved these changes
Apr 18, 2019
antho1404
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to check commit by commit.
Modifs:
name: ""anddescription: ""(will add them back with content later).manifestServiceDatainpreparePublishServiceVersionbasicfull definition of service definition