Marketplace: load manifest on demand #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ilgooz
reviewed
Apr 18, 2019
| export interface Version { | ||
| versionHash: string; | ||
| manifest: string; | ||
| manifestProtocol: string; | ||
| manifestData: Manifest|null; |
There was a problem hiding this comment.
how about changing this to manifestData?: Manifest; and after this change we can set the manifestData directly into https://github.com/mesg-foundation/core/pull/896/files#diff-1497f2b1650c529c8f58159491cfe107R8 instead of recreating the object
There was a problem hiding this comment.
I feel it's safer to have multiple type. Like this, manifestData doesn't exist in Version and the developer cannot confuse between a not loaded manifestData and an not existing one (when the file is no more accessible from IPFS).
ilgooz
suggested changes
Apr 18, 2019
NicolasMahe
force-pushed
the
ss/marketplace-manifest-ondemand-loading
branch
from
6f98fe3
to
2284c8c
Compare
Done. Please review |
# Conflicts: # systemservices/marketplace/src/contracts/version.ts # systemservices/marketplace/src/tasks/isAuthorized.ts
ilgooz
previously approved these changes
Apr 19, 2019
# Conflicts: # systemservices/marketplace/src/contracts/version.ts
ilgooz
previously approved these changes
Apr 22, 2019
antho1404
previously approved these changes
Apr 22, 2019
…tplace-manifest-ondemand-loading # Conflicts: # systemservices/marketplace/mesg.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr change the way the manifest is downloaded.
Before, getting the version also download the manifest.
Now, the manifest needs to be explicitly downloaded.
Task
getServicestill returns the manifest, but tasklistServicedoesn'tTODO: