Merge pull request #521 from mesg-foundation/fix/remove-point

Remove point at the end of sentence

api/deploy.go

@@ -97,7 +97,7 @@ func (d *serviceDeployer) FromGitURL(url string) (*service.Service, *importer.Va
 		return nil, nil, err
 	}
 
-	d.sendStatus("Service downloaded with success.", DonePositive)
+	d.sendStatus("Service downloaded with success", DonePositive)
 	r, err := xarchive.GzippedTar(path)
 	if err != nil {
 		return nil, nil, err

api/deploy_test.go

@@ -42,7 +42,7 @@ func TestDeployService(t *testing.T) {
 	}, <-statuses)
 
 	require.Equal(t, DeployStatus{
-		Message: "Service context received with success.",
+		Message: "Service context received with success",
 		Type:    DonePositive,
 	}, <-statuses)
 
@@ -52,7 +52,7 @@ func TestDeployService(t *testing.T) {
 	}, <-statuses)
 
 	require.Equal(t, DeployStatus{
-		Message: "Image built with success.",
+		Message: "Image built with success",
 		Type:    DonePositive,
 	}, <-statuses)
 
@@ -88,7 +88,7 @@ func TestDeployInvalidService(t *testing.T) {
 	}, <-statuses)
 
 	require.Equal(t, DeployStatus{
-		Message: "Service context received with success.",
+		Message: "Service context received with success",
 		Type:    DonePositive,
 	}, <-statuses)
 
@@ -126,7 +126,7 @@ func TestDeployServiceFromURL(t *testing.T) {
 	}, <-statuses)
 
 	require.Equal(t, DeployStatus{
-		Message: "Service downloaded with success.",
+		Message: "Service downloaded with success",
 		Type:    DonePositive,
 	}, <-statuses)
 
@@ -136,7 +136,7 @@ func TestDeployServiceFromURL(t *testing.T) {
 	}, <-statuses)
 
 	require.Equal(t, DeployStatus{
-		Message: "Service context received with success.",
+		Message: "Service context received with success",
 		Type:    DonePositive,
 	}, <-statuses)
 
@@ -146,7 +146,7 @@ func TestDeployServiceFromURL(t *testing.T) {
 	}, <-statuses)
 
 	require.Equal(t, DeployStatus{
-		Message: "Image built with success.",
+		Message: "Image built with success",
 		Type:    DonePositive,
 	}, <-statuses)
 

commands/provider/service_provider.go

@@ -233,7 +233,7 @@ func (p *ServiceProvider) ServiceValidate(path string) (string, error) {
 	}
 
 	if !validation.ServiceFileExist {
-		return fmt.Sprintf("%s File 'mesg.yml' does not exist.", pretty.FailSign), nil
+		return fmt.Sprintf("%s File 'mesg.yml' does not exist", pretty.FailSign), nil
 	}
 
 	if len(validation.ServiceFileWarnings) > 0 {
@@ -245,10 +245,10 @@ func (p *ServiceProvider) ServiceValidate(path string) (string, error) {
 	}
 
 	if !validation.DockerfileExist {
-		return fmt.Sprintf("%s Dockerfile does not exist.", pretty.FailSign), nil
+		return fmt.Sprintf("%s Dockerfile does not exist", pretty.FailSign), nil
 	}
 	if !validation.IsValid() {
-		return fmt.Sprintf("%s Service is not valid.", pretty.FailSign), nil
+		return fmt.Sprintf("%s Service is not valid", pretty.FailSign), nil
 	}
 
 	return fmt.Sprintf(`%s Dockerfile exists

commands/service_delete.go

@@ -66,7 +66,7 @@ func (c *serviceDeleteCmd) runE(cmd *cobra.Command, args []string) error {
 		if err != nil {
 			return err
 		}
-		fmt.Printf("%s all services are deleted.\n", pretty.SuccessSign)
+		fmt.Printf("%s all services are deleted\n", pretty.SuccessSign)
 		return nil
 	}
 

commands/service_dev.go

@@ -70,18 +70,18 @@ func (c *serviceDevCmd) runE(cmd *cobra.Command, args []string) error {
 			err = c.e.ServiceDelete(id)
 		})
 		if err != nil {
-			fmt.Printf("%s Error while removing the service.\n", pretty.FailSign)
+			fmt.Printf("%s Error while removing the service\n", pretty.FailSign)
 			fmt.Printf(pretty.Failln(err))
 		} else {
-			fmt.Printf("%s Service removed.\n", pretty.SuccessSign)
+			fmt.Printf("%s Service removed\n", pretty.SuccessSign)
 		}
 	}()
 
 	pretty.Progress("Starting the service...", func() { err = c.e.ServiceStart(id) })
 	if err != nil {
 		return err
 	}
-	fmt.Printf("%s Service started.\n", pretty.SuccessSign)
+	fmt.Printf("%s Service started\n", pretty.SuccessSign)
 
 	listenEventsC, eventsErrC, err := c.e.ServiceListenEvents(id, c.eventFilter)
 	if err != nil {

commands/service_execute.go

@@ -90,7 +90,7 @@ func (c *serviceExecuteCmd) runE(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return err
 	}
-	fmt.Printf("%s Task %q executed.\n", pretty.SuccessSign, c.taskKey)
+	fmt.Printf("%s Task %q executed\n", pretty.SuccessSign, c.taskKey)
 
 	var result *coreapi.ResultData
 	pretty.Progress("Waiting for result...", func() {

commands/service_init.go

@@ -79,7 +79,7 @@ func (c *serviceInitCmd) preRunE(cmd *cobra.Command, args []string) error {
 	}
 
 	if result == addMyOwn {
-		fmt.Println("You can create and add your own template to this list.")
+		fmt.Println("You can create and add your own template to this list")
 		fmt.Println("Go to the Awesome Github to see how")
 		fmt.Println("https://github.com/mesg-foundation/awesome")
 		os.Exit(0)
@@ -113,7 +113,7 @@ func (c *serviceInitCmd) runE(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return err
 	}
-	fmt.Printf("%s Service initialized in %q.\n", pretty.SuccessSign, c.dir)
+	fmt.Printf("%s Service initialized in %q\n", pretty.SuccessSign, c.dir)
 	return nil
 }
 

commands/service_start.go

@@ -18,7 +18,7 @@ func newServiceStartCmd(e ServiceExecutor) *serviceStartCmd {
 	c.cmd = newCommand(&cobra.Command{
 		Use:     "start SERVICE",
 		Short:   "Start a service",
-		Long:    "Start a service previously published services.",
+		Long:    "Start a service previously published services",
 		Example: `mesg-core service start SERVICE`,
 		Args:    cobra.ExactArgs(1),
 		RunE:    c.runE,
@@ -37,7 +37,7 @@ func (c *serviceStartCmd) runE(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return err
 	}
-	fmt.Printf("%s Service started.\n", pretty.SuccessSign)
+	fmt.Printf("%s Service started\n", pretty.SuccessSign)
 	fmt.Printf("To see its logs, run the command:\n\tmesg-core service logs %s\n", serviceID)
 	return nil
 }

commands/service_stop.go

@@ -33,6 +33,6 @@ func (c *serviceStopCmd) runE(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return err
 	}
-	fmt.Printf("%s Service stopped.\n", pretty.SuccessSign)
+	fmt.Printf("%s Service stopped\n", pretty.SuccessSign)
 	return nil
 }

commands/start.go

@@ -53,6 +53,6 @@ func (c *startCmd) runE(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	fmt.Printf("%s Core started.\n", pretty.SuccessSign)
+	fmt.Printf("%s Core started\n", pretty.SuccessSign)
 	return nil
 }

commands/start_test.go

@@ -16,7 +16,7 @@ func TestStartCmdRunE(t *testing.T) {
 	c.cmd.Execute()
 
 	stdout, stderr := closeStd()
-	require.Contains(t, stdout, "Starting Core.")
+	require.Contains(t, stdout, "Starting Core")
 	require.Contains(t, stdout, "Core started")
 	require.Empty(t, stderr)
 

commands/status.go

@@ -18,7 +18,7 @@ func newStatusCmd(e RootExecutor) *statusCmd {
 	c := &statusCmd{e: e}
 	c.cmd = newCommand(&cobra.Command{
 		Use:   "status",
-		Short: "Get the Core's status.",
+		Short: "Get the Core's status",
 		RunE:  c.runE,
 	})
 	return c

database/service_db.go

@@ -25,7 +25,7 @@ type DecodeError struct {
 }
 
 func (e *DecodeError) Error() string {
-	return fmt.Sprintf("Database services: Could not decode service %q.", e.ID)
+	return fmt.Sprintf("Database services: Could not decode service %q", e.ID)
 }
 
 // IsErrNotFound returs true if err is type of ErrNotFound, false otherwise.

interface/grpc/core/deploy_integration_test.go

@@ -21,7 +21,7 @@ func TestIntegrationDeployService(t *testing.T) {
 
 	require.Len(t, stream.serviceID, 40)
 	require.Contains(t, stream.statuses, api.DeployStatus{
-		Message: "Image built with success.",
+		Message: "Image built with success",
 		Type:    api.DonePositive,
 	})
 }

interface/grpc/core/deploy_test.go

@@ -23,7 +23,7 @@ func TestDeployService(t *testing.T) {
 	require.Len(t, stream.serviceID, 40)
 
 	require.Contains(t, stream.statuses, api.DeployStatus{
-		Message: "Image built with success.",
+		Message: "Image built with success",
 		Type:    api.DonePositive,
 	})
 }

service/service.go

@@ -173,7 +173,7 @@ func (s *Service) saveContext(r io.Reader) error {
 	}
 
 	s.sendStatus("Receiving service context...", DRunning)
-	defer s.sendStatus("Service context received with success.", DDonePositive)
+	defer s.sendStatus("Service context received with success", DDonePositive)
 
 	return archive.Untar(r, s.tempPath, &archive.TarOptions{
 		Compression: archive.Gzip,
@@ -198,7 +198,7 @@ func (s *Service) deploy() error {
 		return err
 	}
 
-	s.sendStatus("Image built with success.", DDonePositive)
+	s.sendStatus("Image built with success", DDonePositive)
 
 	s.configuration.Key = "service"
 	s.configuration.Image = imageHash

service/service_test.go

@@ -1,7 +1,6 @@
 package service
 
 import (
-	"sync"
 	"testing"
 
 	"github.com/mesg-foundation/core/container"
@@ -68,33 +67,7 @@ func TestNew(t *testing.T) {
 	archive, err := xarchive.GzippedTar(path)
 	require.NoError(t, err)
 
-	statuses := make(chan DeployStatus)
-	var wg sync.WaitGroup
-
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
-
-		require.Equal(t, DeployStatus{
-			Message: "Receiving service context...",
-			Type:    DRunning,
-		}, <-statuses)
-
-		require.Equal(t, DeployStatus{
-			Message: "Service context received with success.",
-			Type:    DDonePositive,
-		}, <-statuses)
-
-		require.Equal(t, DeployStatus{
-			Message: "Building Docker image...",
-			Type:    DRunning,
-		}, <-statuses)
-
-		require.Equal(t, DeployStatus{
-			Message: "Image built with success.",
-			Type:    DDonePositive,
-		}, <-statuses)
-	}()
+	statuses := make(chan DeployStatus, 4)
 
 	s, err := New(archive,
 		ContainerOption(mc),
@@ -104,8 +77,27 @@ func TestNew(t *testing.T) {
 	require.Equal(t, "service", s.Dependencies[0].Key)
 	require.Equal(t, hash, s.Dependencies[0].Image)
 
+	require.Equal(t, DeployStatus{
+		Message: "Receiving service context...",
+		Type:    DRunning,
+	}, <-statuses)
+
+	require.Equal(t, DeployStatus{
+		Message: "Service context received with success",
+		Type:    DDonePositive,
+	}, <-statuses)
+
+	require.Equal(t, DeployStatus{
+		Message: "Building Docker image...",
+		Type:    DRunning,
+	}, <-statuses)
+
+	require.Equal(t, DeployStatus{
+		Message: "Image built with success",
+		Type:    DDonePositive,
+	}, <-statuses)
+
 	mc.AssertExpectations(t)
-	wg.Wait()
 }
 
 func TestInjectDefinitionWithConfig(t *testing.T) {

utils/clierrors/error.go

@@ -12,7 +12,7 @@ const (
 	cannotReachTheCore = "Cannot reach the Core"
 	startCore          = "Please start the core by running: mesg-core start"
 	cannotReachDocker  = "Cannot reach Docker"
-	installDocker      = "Please make sure Docker is running.\nIf Docker is not installed on your machine you can install it here: https://store.docker.com/search?type=edition&offering=community"
+	installDocker      = "Please make sure Docker is running\nIf Docker is not installed on your machine you can install it here: https://store.docker.com/search?type=edition&offering=community"
 )
 
 // ErrorMessage returns error description based on error type.