Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Struct from proto instead of map[string]interface #1302

Closed
5 of 6 tasks
NicolasMahe opened this issue Sep 4, 2019 · 1 comment
Closed
5 of 6 tasks

Use Struct from proto instead of map[string]interface #1302

NicolasMahe opened this issue Sep 4, 2019 · 1 comment
Assignees

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Sep 4, 2019

The proto are using Struct and map[string]*Value from proto.
The engine should also use it instead of the custom map[string]interface.

Then, good stuff that can be done:

  • change type of process.filter to Value (currently String)
@NicolasMahe
Copy link
Member Author

I'm closing this issue as the modif has been done in the Engine and we decided to not do it for ethwallet (see related PR for more info).

@NicolasMahe NicolasMahe removed this from the v0.15.0 milestone Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants