Do not convert proto.Struct to map in order to Validate it #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
refator/validate-servcie-struct
branch
2 times, most recently
from
6a42e6b
to
75305f1
Compare
krhubert
force-pushed
the
refator/validate-servcie-struct
branch
from
75305f1
to
06ad334
Compare
NicolasMahe
reviewed
Sep 7, 2019
NicolasMahe
approved these changes
Sep 7, 2019
antho1404
approved these changes
Sep 8, 2019
This was referenced Sep 9, 2019
NicolasMahe
added a commit
that referenced
this pull request
Sep 11, 2019
…- original commit 06ad334
NicolasMahe
added a commit
that referenced
this pull request
Sep 11, 2019
Merged
NicolasMahe
added a commit
that referenced
this pull request
Sep 11, 2019
NicolasMahe
added
the
release:change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's part of #1302 issue, where the service validation is done.
I need to do manual testing, but the source code is ready to review.