Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config validation #1387

Closed
NicolasMahe opened this issue Oct 1, 2019 · 1 comment · Fixed by #1449
Closed

Improve config validation #1387

NicolasMahe opened this issue Oct 1, 2019 · 1 comment · Fixed by #1449
Assignees
@krhubert

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Oct 1, 2019 •
edited
Loading

From #1380 (comment)

The config validation on the Log.Format should use go.validator system.
Add oneof=text json > https://godoc.org/gopkg.in/go-playground/validator.v9#hdr-One_Of
With that, we can remove l149 and we could do the same for the logLevel.
@krhubert
Copy link
Contributor

krhubert commented Oct 1, 2019

For log format yes, for log level is still better to use Parse instead of rewrite all levels from logrus :)

@krhubert krhubert mentioned this issue Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krhubert krhubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config log format validation mesg-foundation/engine
2 participants
@krhubert @NicolasMahe