Add configuration validation #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
force-pushed
the
feature/config-validation
branch
from
b4dbd65
to
8e70be7
Compare
…rTx is valid. Remove some test as there is require value without default value
NicolasMahe
force-pushed
the
feature/config-validation
branch
from
cb7a3a7
to
3254d45
Compare
|
I add the required flag on all data even if it means that the default config (without envs) is not valid anymore. |
NicolasMahe
approved these changes
Sep 30, 2019
antho1404
reviewed
Oct 1, 2019
| } | ||
|
|
||
| Log struct { | ||
| Format string | ||
| Format string `validate:"required"` |
There was a problem hiding this comment.
We could add oneof=text json > https://godoc.org/gopkg.in/go-playground/validator.v9#hdr-One_Of
With that, we can remove l149 and we could do the same for the logLevel
antho1404
approved these changes
Oct 1, 2019
NicolasMahe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1376
Add validation for required fields + require minium one signers