Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove DependenciesFromService #393

Closed
ilgooz opened this issue Aug 26, 2018 · 1 comment
Closed

remove DependenciesFromService #393

ilgooz opened this issue Aug 26, 2018 · 1 comment
Assignees
@ilgooz
Labels
enhancement New feature or request question Further information is requested
Milestone
v1.2.0

Comments

@ilgooz
Copy link
Contributor

ilgooz commented Aug 26, 2018

https://github.com/mesg-foundation/core/blob/5b52201/service/dependency.go#L15 remove this method if there is no logic depends on sorted keys.

consider using reflect.DeepEqual to compare maps in tests
@ilgooz ilgooz added the enhancement New feature or request label Aug 26, 2018
@ilgooz ilgooz self-assigned this Aug 26, 2018
@ilgooz ilgooz added this to the v1.2.0 milestone Aug 26, 2018
@NicolasMahe
Copy link
Member

This 'weird' function and struct that it returns is not just a sorted version of the map.
The struct DependencyFromService also have the name of the dependency (the key of the original map) and it allow easier code for starting and stopping services.
Maybe it could become something else in the refactoring of the Service api.

@ilgooz ilgooz added the question Further information is requested label Aug 27, 2018
ilgooz added a commit that referenced this issue Sep 1, 2018
@ilgooz
service: use slices instead maps on Service type, closes #394. minor …
f2c4d88 
…improvements

* make Service type Newable.
* add ServiceDefinition type to service/importer.
* rm unneeded fields in service.proto in interface/grpc/core.
* rm unneeded service.DependenciesFromService(), closes #393.
* rm unneeded TestDependenciesFromService test in service/.
* cleanup service package.
ilgooz added a commit that referenced this issue Sep 3, 2018
@ilgooz
* use slices instead maps on Service type, closes #394.
88fd329 
* use slices instead maps on service.proto.
* add ServiceDefinition type to service/importer.
* rm unneeded fields in service.proto in interface/grpc/core.
* rm unneeded service.DependenciesFromService(), closes #393.
* rm unneeded TestDependenciesFromService test in service/.
* rm unneeded TestSaveReturningHash test in database/services.
* rm unneeded TestInjectConfigurationInDependencies test in api/, TestNew test in service/ covers it.
* move TestInjectConfigurationInDependenciesWithConfig test as TestInjectDefinitionWithConfig from api/ to service/.
* move TestInjectConfigurationInDependenciesWithDependency test as TestInjectDefinitionWithDependency from api/ to service/.
* rm unneeded TestInjectConfigurationInDependenciesWithDependencyOverride test in api/.
* use getters in service package for other needed places.
* rm unnecessary nil checks.
* cleanup service package.
* minor improvements.
ilgooz added a commit that referenced this issue Sep 3, 2018
@ilgooz
service: make Service type Newable, fundamental part of #337
3c5ec2b 
* use slices instead maps on Service type, closes #394.
* use slices instead maps on service.proto.
* add ServiceDefinition type to service/importer.
* rm unneeded fields in service.proto in interface/grpc/core.
* rm unneeded service.DependenciesFromService(), closes #393.
* rm unneeded TestDependenciesFromService test in service/.
* rm unneeded TestSaveReturningHash test in database/services.
* rm unneeded TestInjectConfigurationInDependencies test in api/, TestNew test in service/ covers it.
* move TestInjectConfigurationInDependenciesWithConfig test as TestInjectDefinitionWithConfig from api/ to service/.
* move TestInjectConfigurationInDependenciesWithDependency test as TestInjectDefinitionWithDependency from api/ to service/.
* rm unneeded TestInjectConfigurationInDependenciesWithDependencyOverride test in api/.
* use getters in service package for other needed places.
* rm unnecessary nil checks.
* cleanup service package.
* minor improvements.
ilgooz added a commit that referenced this issue Sep 4, 2018
@ilgooz
service: make Service type Newable, fundamental part of #337
419ac0e 
* use slices instead maps on Service type, closes #394.
* use slices instead maps on service.proto.
* add ServiceDefinition type to service/importer.
* rm unneeded fields in service.proto in interface/grpc/core.
* rm unneeded service.DependenciesFromService(), closes #393.
* rm unneeded TestDependenciesFromService test in service/.
* rm unneeded TestSaveReturningHash test in database/services.
* rm unneeded TestInjectConfigurationInDependencies test in api/, TestNew test in service/ covers it.
* move TestInjectConfigurationInDependenciesWithConfig test as TestInjectDefinitionWithConfig from api/ to service/.
* move TestInjectConfigurationInDependenciesWithDependency test as TestInjectDefinitionWithDependency from api/ to service/.
* rm unneeded TestInjectConfigurationInDependenciesWithDependencyOverride test in api/.
* use getters in service package for other needed places.
* rm unnecessary nil checks.
* cleanup service package.
* minor improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilgooz ilgooz

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@NicolasMahe @ilgooz