-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trigger type for workflows #1229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
requested review from
NicolasMahe and
krhubert
and removed request for
NicolasMahe
August 15, 2019 07:20
antho1404
force-pushed
the
feature/trigger-type-oneof
branch
from
August 15, 2019 09:43
76db3d7
to
5dd4b50
Compare
NicolasMahe
reviewed
Aug 16, 2019
Co-Authored-By: Nicolas Mahé <nicolas@mesg.com>
…foundation/engine into feature/trigger-type-oneof
…eof-nico Use required_without validation instead of manual one
NicolasMahe
approved these changes
Aug 16, 2019
NicolasMahe
added
the
release:change
Pull requests that change something existant
label
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger now has 2 fields
taskKey
eventKey
instead of a generic
key
(that was confusing with thenodeKey
).The proto definition now uses a
oneof
for this.I also changed the scheduler to have two functions for
processEvent
andprocessResult
this creates a bit of duplication but makes it much easier.TEST:
You can still take the services dataset from #1209
but the workflows need to be updated with: